Mateusz Zaremba
Mateusz Zaremba
I've made a proposition of changes to the documentation which would drop the usage of ARG and environment variables and would instead promote the usage of Docker build secrets.
@MylesBorins @monishcm any chance you could have a look please?
@ljharb @MylesBorins @trevrosen any chance on getting feedback on this please?
@MylesBorins @monishcm I think this is ready for another review.
I've run `npm install` and pushed a commit with updated `package-lock.json` so all the test pass but it seems to have caused merge conflict which I can't solve w/out the...
> @matzar Yes, can you try removing the `package-lock.json` from this PR and see if the deployment succeeds? @lukekarrys I've removed `package-lock.json` and [build-and-upload](https://github.com/npm/documentation/runs/8306158224?check_suite_focus=true#logs) fails but it's on installing npm...
> @matzar can you try rebasing your PR against the `main` branch and force pushing. I'm not sure how you ended up in the situation you are in right now...
@MylesBorins I think you were concerned about that Docker image not working on CI? This works for me with GitHub Actions: ```yml - name: Build and Push Docker image run:...
@smshareef026 if you haven't already and this wasn't just a testing token, I'd recommend deleting this screenshot showing your GitHub Personal Access Token.
@MylesBorins @monishcm I've tried to address the previous concerns but maybe I could improve this PR in any way?