Matute
Matute
I updated the description to indicate the items in D3 I am able to sign-off at this point.
clkmgr was declared D2S on 18772a9 on Mar 9, 2022. and the current state is at 49fd66a73ae0c3e5f47077f32ba0b7120ed61d30. The clkmgr code location changed from hw/ip/clkmgr to hw/ip_templates/clkmgr when it was generated...
Along the same line of the pwrmgr and rstmgr, for clkmgr the right comparison is between the generated files under hw/top_earlgrey/ip/clkmgr/rtl and the current files. I also updated the comment...
Hey Amaury, where do you expect the per-top SW files to reside? Not just the parameters, but the actual functions that will be top-specific?
Regarding my last question about generated SW, this is a drawback of not committing generated files: to see the changes I will need to copy the PR, build, and inspect...
CHANGE AUTHORIZED: hw/ip_templates/rstmgr/data/rstmgr.hjson.tpl CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/rstmgr/data/rstmgr.hjson
@andreaskurth I made the suggested changes. Thanks.
The verible lint issues are cleared, and I fixed the initialization in flash_ctrl_read_word_sweep, where the addresses need to be otf_addr_t instead of addr_t.
@rswarbrick the formatting changes were for diffs from util/lintpy.py, and the funny change you are referring to is because of line-length. I think in CI we only check changed lines...