mattiZed

Results 15 comments of mattiZed

Maybe these levels should be somewhat based on what they can do to the game. On my minqlbots i had them kinda set up like this: Permlevel 1 -> Pass...

Yeah, thats just the way I handled it. Maybe gives some thoughts!

Hi @sydney-runkle, thanks for the reply on a friday evening ;-) If I change the definition to what you propose, I can not control "from the outside" if `EventBody` has...

Okay, I think I understand your approach. That would require someone who is using the integration package to create a subclass of the base `Event` and then control `Optional` and...

Right, I've implemented the whole situation: ```Python import json from base64 import b64decode from typing import Generic, Optional, TypeVar from pydantic import BaseModel, ValidationInfo, field_validator, ValidationError Q = TypeVar("Q", bound=BaseModel)...

Hi @sydney-runkle, ah, interesting. That supports my initial observation that `E = Event[ Annotated[Optional[EventBody], Field(default=None)] ]` actually does work as expected, _as long as there is no field validator defined...

I think I found another issue: I also need to support generics that have NoneType for a specific field: (Note the `bound=Optional[BaseModel]` on `R`) ```Python from pydantic import BaseModel from...

Hi, I just noticed that I never responded to your last comments. My apologies! We have worked around the problem for now and are fine with your decision. Continue the...

I agree 100%. i will remove string allocation improvement from this pr so it can be merged first. then merging your pr after should be straight forward. will do it...

Either is fine for me, will update this PR now.