matthewvalentine
matthewvalentine
I should probably mention that it looked like a manual .exec() loop wasn't any faster than matchAll, but I didn't investigate that closely.
I have discovered that `match` with a global regex appears to scale linearly for this test. So 1. If I can confirm that, then that's a good mitigation for me...
I fully expect `RE2` to be much slower on average. Like you said, the goal here is predictable performance on bad input. This is a kind of input (a string...
I've confirmed this is entirely from UTF-16 / UTF-8 translation. When using `Buffer` input and `.useBuffers = true` on the replacer, the nonlinearity disappears from both `.matchAll()` and `.replace[All]()`. This...
@uhop Yes, the nonlinearity is gone from my tests as well! Thank you so much
In fact, I _know_ it is functionally broken because it fails the existing tests. Still, I'm look for feedback on the approach.
I split what used to be this comment into https://github.com/uhop/node-re2/issues/201 since it is about master and not this PR. Kept for posterity. Hm, in trying to figure out why it...