Matthew Pull

+1

This is a draft PR as the implementation is not finished yet - I still need to add an implementation for crontab schedule.

So this is my first time properly looking at the Celery codebase and there are a couple of bits I don't really understand. The most important is line 195 of...

> This pull request **introduces 3 alerts** when merging [6428c14](https://github.com/celery/celery/commit/6428c1407ff4c0f393370135003c6a1985114646) into [fad54a9](https://github.com/celery/celery/commit/fad54a99db1aafba505d26c79d7d9368bbeaa4df) - [view on LGTM.com](https://lgtm.com/projects/g/celery/celery/rev/pr-7ccb25aa6196f0c1adbd47ca696e20c5b10b867f) > > **new alerts:** > > * 2 for Wrong name for an argument...

> lgtm alerts are not major issue here. was talking about unit tests Sorry for the confusion, I did understand what you meant earlier but was just trying to address...

To respond to my previous query: > I am probably just missing something, but from my reading of the code I think that line 195 is setting the time zone...

I think the implementation is pretty much there now. Tests are present for the new / changed methods in `time.py`, but I still need to add them for `beat.py` and...

Sorry, this one sort of fell through the cracks the last couple of weeks while I've been working on other projects. I've just added a couple of test cases for...

I have rerun the test suite with the latest master and I do now get a test failing, but its in the mongodb.py code and the error is `"The DNS...

Those are the new ones I made today, to cover the changes in `beat.py`. Just ran the tests again locally and they're still working, and they appear to have passed...