Matthew Hill

Results 43 comments of Matthew Hill

You are right. Once it is in the "all selected" state, clicking it again does nothing (it should deselect everything).

Any update, @EdSchouten? Really appreciate the work you have put in here; it's going to help a lot of people!

@kdy1 why not do what tsc does with `preseveConstEnums` set to `true`? https://www.typescriptlang.org/tsconfig#preserveConstEnums This will basically treat the `const enum` as an `enum`, emit the runtime representation of the latter.

Jasmine is also very lightweight - doesn't come with a bunch of stuff you may or may not need.

I think this is still an issue. @evanw any chance you could take a look?

It seems to me like this is the root of the problem: > This is an issue because our rule interrogates from a pure, isolated module perspective without any types...

It is mentioned [here](https://docs.aspect.build/aspect-build/rules_js/v1.3.1/docs/migrate.html#account-for-change-to-working-directory), but I agree with you it is very unintuitive. Another gotcha not currently mentioned in the docs, is that if you pass `$(execpath :a)` where `a`...

In rules_js/e2e/rules_foo/foo, note the log from `console.log(console.log(require.resolve('@aspect-test/a')))` in main.js: Good case (resolve path is within runfiles): ```shell $ bazel run //foo:main // console.log(console.log(require.resolve('@aspect-test/a'))) /execroot/rules_foo/bazel-out/darwin_arm64-fastbuild/bin/foo/main.sh.runfiles/rules_foo/foo/node_modules/.aspect_rules_js/@[email protected]/node_modules/@aspect-test/a/index.js ``` Bad case (resolve path is...

Thanks @jbedard, this looks great. I noticed that webpack-dev-server is 2-3x slower with the fs patches turned on (WDS does a LOT of brute force directory crawling and symlink probing),...

1. You would chain different rules together to do that. Each rule has a different responsibility. - ts_project: translates TS -> JS files using the TypeScript compiler - nodejs_binary: produces...