Matt Whitehead
Matt Whitehead
Can you confirm a couple of details please? - It looks like you have 9 peers currently, so 10 nodes in total that are available. I'm assuming some of those...
Sorry for the slow reply @kkeaton-rcp . I haven't been able to look into it in detail yet, but another contributor @Brindrajsinh-Chauhan might have some time to do so. I'll...
Looks like I can @Brindrajsinh-Chauhan - just assigned it to you
@daanporon this seems like a reasonable change. Re. the `PeerDiscoveryAgent` always starting, I'm not sure I'm afraid. It may be that disabling discovery doesn't prevent "outbound" UDP-based discovery via bootnodes,...
> @matthew1001 is something else needed in order to get this approved? It looks OK to me, but I think it would be sensible to get @pinges to take a...
> Hi @siladu and @matthew1001 can youse please review this one? > > Cheers. Thanks for updating the PR @amsmota I've left a few more comments, the main one being...
I've just pulled your latest commits on the PR @amsmota and I'm still seeing the behaviour of a new block not being produced if a TX arrives during the empty...
Sorry I couldn't find your previous comment, but that's great if that's the current behaviour. I think I pulled and re-built with your latest changes but I'll check. Here's the...
> I see below those 4 workflows awaiting approval, what should I do to be able to run them? I've just approved them to run, so they're all going now
> Anyway, to be sure is better if somebody else confirms this data. I'll pull your latest commits today and try with a 1 node and 4 node network, but...