Matthew Haines-Young

Results 26 issues of Matthew Haines-Young

[@tfrommen suggested in another PR that we regenerate the `package-lock.json` to use version 2 as a separate Pull Request to keep the size of the change down. ](https://github.com/humanmade/coding-standards/pull/275#discussion_r809226824) One thing...

We are using `npm-package-json-lint` to check that our package.json files comply with certain rules. One of these rules is configured so that you are not allowed to use `devDependencies` in...

Add some basic tests for styles. Follows similar setup to eslint tests. Can increase coverage in future. @tomjn Already did a PR for updating to the latest config already: https://github.com/humanmade/coding-standards/pull/275....

The following code is NOT flagged as an error, but I would expect it to be. Note missing space after the first `(`. ``` get_extended_template_part('atoms/heading', '4', [ 'heading_three' => 'This...

bug
phpcs

The stylelint rule `max-line-length` is set to 100. But I have run into a case where this is longer. My specific situation is the comment at the top of the...

stylelint

The rule [`at-rule-empty-line-before`](https://stylelint.io/user-guide/rules/at-rule-empty-line-before) enforces a line break before anything with an @, which in SCSS can be quite a few things e.g. `@function`. We have this configured to still allow...

bug
stylelint

Just wondering what you think about this @joehoyle The filename is generated using the Args and the file path. If you move the site to a new server, the file...

Unit test

### Avoid use of GLOB_BRACE as is not always available. When I try to run WP Hammer I get the following errors: ``` PHP Warning: Use of undefined constant GLOB_BRACE...

On IE11, you cannot select an item by clicking on the actual thumbnail image in the explorer. It works fine if you click the title, or the area around the...

Revisioned meta fields should show in the revision diff UI. **Changes** - Filter the fields that show in the UI - [note requires updated patch that makes this possible](https://core.trac.wordpress.org/attachment/ticket/20564/30033.diff) -...