Matt Clegg
Matt Clegg
I'm trying to use a chart that has been published to a private GitHub repository. The BrowserDownloadURL from GitHub API doesn't work with "personal access tokens" (which I need to...
Ok @krajorama Rebased/signed & cherry-picked relevant changes to this PR.
Merged upstream (again) @krajorama
OK, @robertsirc What would you like to see as a test for this? - [NewHTTPGetter to contain the accept Header](https://github.com/mattclegg/helm/pull/1) - [Server with varied Accept Header](https://github.com/mattclegg/helm/pull/2) - [Ensure headers set...
Thanks for clarifying @robertsirc Like this; https://github.com/mattclegg/helm/pull/2/files ?
@robertsirc The [other PRs](https://github.com/mattclegg/helm/pulls?q=is%3Apr+is%3Aopen+issue-9507) are to avoid having noise on this branch for other tests that aren't needed. I've merged the test for the [server with varied Accept Header](https://github.com/helm/helm/pull/13034/commits/866bc05bb29aca832fcee6a911e341996403153c) to...
@robertsirc @mattfarina @gjenkins8 If you don't mind, could you please check if anything else is needed for this PR?
Would it be possible to get a second approval or any comment from another maintainer, please? @gjenkins8 @jdolitsky @joejulian @marckhouzam @sabre1041 @scottrigby @technosophos
@TerryHowe I'm not using ghcr? I'm using a private helm chart hosted with GitHub. The issue is also described in #9507 > .. when downloading release binary requires such an...
LGTM but I don't have permission for the checks to run as I'm not a maintainer.