mats-knmi
mats-knmi
@sidekock, since I am planning on starting with the blending conversion to xarray as well soon, I would appreciate it if you could create a draft pull request from the...
I am sorry for only commenting now. I have been busy with some other stuff. I will go over the changes and leave some input where I have it. If...
I have left my comments, let me know what you think. Again, sorry for taking so long to get back to you. Overall the code looks much more manageable now,...
Looks good, I added 2 small comments on the type hinting, but other than that I think this makes it a lot nicer indeed. Regarding the private discussion: Every method...
@sidekock I resolved all my comments that are fully resolved now, I left 2 open, since those are not fully resolved yet. I think the docstring comment is important to...
Yes they are approved. ~~I wanted to approve them in github, but I can't find the button to do this. Not sure if I am just blind or if I...
Hi, just got back from my holiday, so I can take a look. @bwalraven I am not sure if we need to change the check norain method or the way...
@larsbonnefoy I have now merged the other PR. So you can take a look at this one if you still want to. @sidekock has already reviewed this one.