Mathias
Mathias
It appears that Prettier might have formatted the inline snapshots differently, I'm not sure why 🤔
Before I will call this _Ready to be merged_, I have a few questions: 1. ~~Is it okay that I remove part of a test, that was causing the type...
> Sorry for taking so long. No worries! This is hardly an urgent issue, so thanks for taking the time to review :-)
@eps1lon I think I finally understood the difference between error handling in internal and public facing functions, so the PR should be ready again now :-)
Thanks for the fast reply! That is an odd configuration indeed, I meant `PLAYCANVAS_BAD_FOLDER_REG` not `PLAYCANVAS_TARGET_DIR` oops. My `pcconfig.json` looks like this: ```json { "PLAYCANVAS_BRANCH_ID": "85605eed-1576-4bd7-a2dd-fe90cd6b0d9c", "PLAYCANVAS_PROJECT_ID": 955349, "PLAYCANVAS_BAD_FILE_REG": "^\\.|~$|package.json|jsconfig.json|tsconfig.json|.ts$|pcignore.txt|pcconfig.json",...
It turns out that I can greatly simplify my configuration if I use the subdir option, now all I need for my pcconfig.json is: ```json { "PLAYCANVAS_BRANCH_ID": "85605eed-1576-4bd7-a2dd-fe90cd6b0d9c", "PLAYCANVAS_PROJECT_ID": 955349,...
Good idea! :-) Will you add a description of this option to the README? https://github.com/mathiassoeholm/markdown-link-updater/blob/main/README.md#extension-settings
Hey 👋 Glad you found it useful! :-) I'm not sure what a reference-style link is. Do you have an example?
Thanks for reporting the issue @jbarossitrs and thanks for investigating @alex-broad! I think I agree with @alex-broad on this, that absolute paths should probably be avoided. At least it's not...
That sounds like a great addition :-) I'm a bit pressured on time at the moment, but I'll gladly implement it when I find the time.