Mathias Hauser
Mathias Hauser
Yes good point - just calling compute may be the better solution.
Currently most warnings (> 1500 of 1900) stem from netCDF4. They should be fixed in the newest netCDF4 version (1.5.4). See https://github.com/Unidata/netcdf4-python/blob/master/Changelog (`alen` -> `len` and `tostring` -> `tobytes`). However,...
> Are the functions you are considering using this functions that never had keyword arguments before? When I wrote a similar decorator before i had an explicit list of arguments...
I just realized that there is a bug in the decorator for "keyword-only arguments without a default". I wonder if I should fix this or just disallow this pattern, i.e....
I also just realized, that we made many arguments keyword-only without deprecation (e.g. `xr.Dataset.mean`) - but that should not stop us from using this - there are still a lot...
Any objections to merge this as is?
Both look good - but adding an intermittent dependency seems a bit heavy...
I just discovered the scikit-learns decorator to deprecate positional args - see https://github.com/scikit-learn/scikit-learn/pull/13311 - and now have a preference for this one. It seems the simplest and does not need...
I just realized that @hmaarrfk's decorator works similarly, but it also has some bells and whistles we probably don't need..?
I just opened #6910 - feedback welcome. > These decorators are kinda fun to write and are quite taylored to a certain release philosophy. > It might be warranted to...