Mohammed Ismail
Mohammed Ismail
can I work on this ?
hi ! from where do we extract the HR data
hey @andrewpollock , apologise for the delay in getting back to you. I'll be updating the code with the requested changes asap.
> @masterismail there's still some formatting errors with this change. Have you run https://github.com/google/osv.dev/blob/master/tools/lint_and_format.sh on it locally? If you run `yapf -i gcp/api/server.py` it should fix them. yes, I have...
> Are you as a contributor able to view https://github.com/google/osv.dev/actions/runs/5795924263/job/15708435878?pr=1455 ? That's showing the output of running `lint_and_format.sh` as part of our CI pipeline. yes, i'm able to see those...
> > this is what I am getting > > Hi, have you set up your local development environment per https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md#contributing-code? yes, I did
> > yes, i'm able to see those test fails > > Cool, do you understand what you need to do to get your PR to pass, based on the...
I've committed the changes as requested !
@PavelMakarchuk , is the implementation exactly the same as #4504 ? What testing methodology did you use to write the tests ? I've been trying to solve this issue [here](https://github.com/PolicyEngine/policyengine-us/compare/master...masterismail:policyengine-us:masterismail/issue4503)
How can I effectively test changes made to policyengine-us locally on the web app?