Justin Mason

Results 36 issues of Justin Mason

In their current state, they don't test a lot about the shape or required parameters of the request payload itself. See these [comments ](https://github.com/keenlabs/KeenClient-Python/pull/132#discussion_r145886823) for context.

As per comments [here](https://github.com/keenlabs/KeenClient-Python/pull/132#pullrequestreview-65019577). Also, the `SavedQueriesInterface` I believe has its own version of the get_json/error_handling stuff for some reason, which could possibly be shared.

A few straggling issue that are still specific to deprecated/varying versions: - The TOX config still refers to `py26` , `py32` and `py33` and is missing versions. - The `setup.py`...

Investigate what happens when trying to do an update of a Saved/Cached Query definition such that an element in a nested array is the target of the update. Filters, Funnel...

Investigate what happens when trying to do an update of a Saved/Cached Query definition such that an element in a nested array is the target of the update. Filters, Funnel...

`KeenQueryClientException` seems to have been created as the exception that should be thrown out of `KeenQueryClient` and the comment says that even includes errors reported by the server: ```Exceptions thrown...

We should work on making it easier to do lower-level validation of HTTP requests in the query tests. `KeenQueryTestBase` might be a good place to share this functionality since this...

In order to deal with HTTP responses that can contain either a root JSON Object or a root JSON Array, at a low level we have to check the structure...

When we call `onSuccess()`/`onFailure` on `KeenCallback`/`KeenDetailedCallback` we swallow any exceptions. It probably makes sense to not generate exceptions unless debug mode is turned on, if those exceptions were raised in...

Parsing responses into the various types of `QueryResult` is quite a bit of complex code at this point, and it's all nestled right in with the rest of `KeenQueryClient`, which...