Mason Chen
Mason Chen
+1 for this feature. We should be able to solve this within spinnaker and not use undesired workarounds
@PatrickRen can you help review? I can't request reviewers unfortunately :)
@MartijnVisser @PatrickRen sorry for the delay, feedback should be addressed. Will followup with the public API change separately.
@PatrickRen have a chance to take another look?
@PatrickRen Thanks, the comments should be addressed! Regarding your earlier comment about the Public API change originally in this PR, I have filed https://issues.apache.org/jira/browse/FLINK-30200 and will followup later
I also encountered this nasty bug and looks like it is fixed via this commit: https://github.com/OpenAPITools/openapi-generator/pull/13630 The 6.4.0 upgrade and configOption mentioned above are what fixed it for me. IMO,...
This shaves 1-2 minutes from CI
I don't think we need 3.1 to support Flink 1.17 and Flink 1.18. We can use 3.0 for the purpose of supporting 1.17, but we need to continue supporting patch...
@hhktseng were you able to test that this change mitigates your original issue? Is there a way to repro in the tests?
@sunxiaojian have you considered implementing this as a Flink format? You could draw inspiration from pre-existing formats: https://github.com/apache/flink/tree/master/flink-formats/flink-json/src/main/java/org/apache/flink/formats/json For example, the debezium json format already has an integration with Kafka...