Martin Traverso
Martin Traverso
Did it sign it? 😜
For functions such as lead and lag, the window frame is not supported. Per the SQL specification: ``` 5) If , , or ROW_NUMBER is specified, then: a) ... b)...
We need to preserve the copyright notice in those files, but it doesn't need to be laid out verbatim. See how we do it in other places, such as: https://github.com/trinodb/trino/blob/daa0a44fb1e3a7c9336e552abdf74ef6a79893ac/core/trino-spi/src/main/java/io/trino/spi/predicate/Primitives.java#L22
The SQL spec reserves double colon for static method invocations, so that's incompatible with this proposed cast syntax. ``` ::= [ ] ``` For example, given: `foo::bar`, it could be...
> What should happen in we fast-forward a branch to itself. Currently it fails. I suggested it could be a noop. Yes, that should be a no-op. > Do we...
How does this interact with IntelliJ?
> badly but at least it's not breaking IntelliJ :) How so? Can you elaborate? If this doesn't work seamlessly with IntelliJ, then it's a non-starter.
@cla-bot check
cc @nineinchnick
Plugins should not expose global functions going forward. That approach is legacy, since trino supports function namespaces.