Martin Traverso

What happens when a node fails and restarts with the same IP and node id? This is a legitimate case, as the node id is expected to be stable for...

Hmm... looks like something is broken in the repo (or in git 1.7.2). I get the following with git 1.7.2: fatal: missing object 0000000000000000000000000000000000000000 for refs/remotes/yorktown/HEAD

In particular, here are some inconsistencies: 1) ``` SELECT k, count(*) FROM (VALUES 1,2,3) t(k) GROUP BY ALL ``` produces a result, but ``` SELECT k, count(*) FROM (VALUES 1,2,3)...

To be clear, the ALL and DISTINCT qualifiers control whether grouping sets that have the same combination of keys are deduped. Therefore, the only way this syntax makes sense is...

> Should this be a client-side thing, @martint ? Yes, see my comment in the issue. IMO, it should either be a CLI rendering option or an addition to the...

In Trino, `timestamp with time zone` is rendered with it's stored time zone. This is intentional, as the insertion time zone is considered to have meaning. Readers can choose to...

> WITH SESSION that allows for tz switch would address the last concern, correct? Yes, but that's the smallest of the issues. It still requires introducing a processing layer to...

> By using the now deprecated syntax, we are able to do insertions into a versioned Iceberg table. That should probably be rejected, as it’s semantically meaningless and potentially confusing...

@Damans227, that would be great! The changes can be done mostly incrementally by tackling individual test classes. Take a look at the PR I linked above for an example.

I only updated `trino-parser` and a small portion of `trino-main`. The goal would be to replace it everywhere.