Martin Emde comments

Results 77 comments of


                                            Martin Emde

[pro] Pundit - naming of `pundit_role`

`pundit_role:` is a bit semantically awkward. I like your default graphql-pro approach of `authorize: :create` (or `authorize: :patient` in our case). What was the rationale for adding the library name...

Currency attribute is ignored in Rate

I allowed access to all data in PR #122 to solve this and other issues.

transit_time=nil response for all shipping service types except ground

I've solved this with #122. Please see details there.

Support shipment LabelSpecification PrintedLabelOrigin element

Looks like this can be closed, because #105 was closed.

Fix `ENAMETOOLONG` error when creating compact index cache

@deivid-rodriguez Any reason this shouldn't merge? Seems good.

Fix `ENAMETOOLONG` error when creating compact index cache

@jcogilvie Thanks for letting us know this is affecting you. I'm working on a test fix now.

Fix `ENAMETOOLONG` error when creating compact index cache

I got a windows pc (almost entirely) to be able to diagnose these broken tests. Once I have it up and running I will update. (The windows tests are often...

Bundler lockfile checksums

Merged in #6374.

Incompatible gems in optional groups is more difficult since Bundler 2.4.21

Thanks for bringing this to our attention. I reviewed all the related Gemfiles and the PRs you linked. Thank you for summarizing it all. Let me see if I understand...

Document rake build:checksum

Are you including the checksums files in the gem? Just a guess? (You would want to not do that.) Is having the checksum in the tag even correct? How can...