martimalek

Results 14 issues of martimalek

### Describe the feature you'd like At the moment Wave has two different places where contribution guidelines are documented: - [Wave's documentation site](https://wave.free-now.com/contributing) - [CONTRIBUTING.md](https://github.com/freenowtech/wave/blob/main/CONTRIBUTING.md) This can lead to potential...

documentation

### Describe the feature you'd like Currently Wave exposes a lot of icons which should accept a [`title`](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title) for accessibility purposes, but the `IconProps` are not expecting this `title`. The...

enhancement
a11y

### Describe the feature you'd like Currently the `Text` component accepts a `secondary` prop which adjusts it's color to indicate secondary information. Since in our semantic colors we already have...

enhancement
conversation needed

Part of #121 In order to offer the best developer experience while using the new semantic colors we should research how to autocomplete the name of the color when using...

enhancement

- `@freenow/wave` version: 1.16.0 ### Relevant code There is a `` in [line 39 of Accordion.tsx](https://github.com/freenowtech/wave/blob/3f561d00ea9ee82cd37f1c20ecb941a2b91a0e3f/src/components/Accordion/Accordion.tsx#L39) and a `` in [line 63 of Accordion.tsx](https://github.com/freenowtech/wave/blob/3f561d00ea9ee82cd37f1c20ecb941a2b91a0e3f/src/components/Accordion/Accordion.tsx#L63) ### What was expected to happen?...

bug
help wanted
design-review

When doing integration tests that use `userEvent` we are not waiting for the DOM "update" but directly expecting behaviour. - `@freenow/wave` version: 1.14.0 ### Relevant code (this is just a...

**What:** Adds missing semantic colors in order to match the ones in the [Designs](https://www.figma.com/file/dTefUItBx5bfbxcCcMzMXm/Wave-DS?node-id=11%3A3). ​ **Why:** We should be aligned with designers. ​ **How:** - Add missing colors in `Colors.ts`...

enhancement

### Describe the feature you'd like There are some differences between the [semantic colors](https://github.com/freenowtech/wave/blob/main/src/essentials/Colors/Colors.ts#L35) in the code and the [Figma file](https://www.figma.com/file/dTefUItBx5bfbxcCcMzMXm/Wave-DS?node-id=11%3A3) that designers use. The goal of this issue would...

enhancement

### Describe the feature you'd like It would be useful to have a way to enforce our PR titles to follow the [conventional commits specification ](https://www.conventionalcommits.org/en/v1.0.0/) since the merge commit...

enhancement
CI/CD

- `@freenow/wave` version: 1.34.1 ### Relevant code styled-components v6 does not filter out props automatically anymore, so they are passed to the component underneath and React warns about it. ![image](https://github.com/freenowtech/wave/assets/46452321/0ff2961c-383d-4e47-a1ed-85177dc2b83f)...

bug
conversation needed