Martijn Laan
Martijn Laan
Thanks. Why did you remove the names of all previous contributors? Can you restore that part?
Thanks. I'm currently away from home and will merge this PR when I get back.
Thanks. I'll look into this a bit later and try to confirm this is a correct fix. (I'm not the original author of ISPP).
> ... the CLA wasn't mentioned in [CONTRIBUTING.md](https://github.com/jrsoftware/issrc/blob/main/CONTRIBUTING.md) (hint, hint), so I didn't know I needed to do new paperwork. Sorry. It's mentioned now.
I'm closing this because it's untested and dont have the time to properly test it myself, nor did I write the original ISPP code so it's hard to do a...
If all cases are tested (using some kind of test script which I could run myself?) and not just the problematic ones that would certainly help. I can also create...
It didn't compile since the Include prototype change was only done in the implementation section but I did it in the interface section as well and this is the resulting...
Thanks! I rearranged the GUI, made it work without duplicate code, cleaned up all the unrelated changes in the PR and did some other stuff but the basic idea is...
I will provide some review comments tomorrow, but I want to say that I'm very impressed with the quality and completeness of your pull requests. Thanks! 👍
> > Looks like ReadFile failure isn't handled correctly > > In addition to the uninitialized bytes, simulating a ReadFile failure with some data read into the buffer (I don't...