Martijn van Dijk

Results 133 comments of Martijn van Dijk

I don't think this is a good approach. We don't force people to use MvxFormsApplication so there is no way to know if it is used inside a page. Any...

I know there was an error in the binding there that i fixed in 6.2.0-beta2, but not sure if it is related. Could you test?

Wouldn't it be possible to detect the splashscreen based on the `[Activity]` attribute with `MainLauncher = true`? Same would go for Intents with Attribute i guess. Also doesn't this do...

In general i think this could also be used in the `NavigationView` since that uses IMenuItem as well. The implementation for that would be a `MvxNavigationView` which would look very...

https://github.com/Baseflow/ExoPlayerXamarin/pull/124 This was merged 2 days ago, and needed to fix this. You had a whole year to open a PR to fix this.

It seems the class has an error when trying to bind the ExoPlayer class. I can't find a fix for it yet.

@richp582 The headers are updated here: https://github.com/martijn00/XamarinMediaManager/blob/develop/MediaManager/Platforms/Android/Player/AndroidMediaPlayer.cs#L257 The actual media source for HLS is created here: https://github.com/martijn00/XamarinMediaManager/blob/64e3191082c6fcdc831c785a718d9810dcada21b/MediaManager/Platforms/Android/Media/MediaItemExtensions.cs#L50 Maybe you can try debug those areas to see where it fails?

@richp582 @JohnGalt1717 @awatertrevi maybe it is a better idea to pay me to fix this instead of making homebrew ;)

I would be happy to review a PR for this. Start with: https://medium.com/google-exoplayer/new-cast-extension-and-demo-app-55816a50012 on Android.

Please fill out a proper feature request.