Martin Lui

Results 6 comments of Martin Lui

lack of osd_per_node causes crash, even with use_existing set to true

I just came across this problem. I've found that this was fixed in https://github.com/ceph/cbt/commit/1c831804ea3c24e5e09c060fbb4f0691369133d2. However, this problem came back and exists in the current master branch. Specifically, it is caused...

Remove inline styles that break plots in strict CSP setups

Yes, I'll try to rebase or merge from master when I get some time after work (possibly in the weekend).

Remove inline styles that break plots in strict CSP setups

@birkskyum, @archmoj, sorry for the delay getting back to this. Per your request, I've merged `master` into this branch. I also fixed the unit tests that had some expectation changes...

Remove inline styles that break plots in strict CSP setups

> > Yes, maplibre appears to be alright, it's only the mapbox traces that are affected by this PR. > > Thanks @birkskyum for testing. @martian111 FYI - we don't...

Remove inline styles that break plots in strict CSP setups

> > Thanks @archmoj and @birkskyum ! I am a bit confused on what you mean by "only the mapbox traces that are affected by this PR". Based on what...

Apply styles to SVG text elements directly as allowed by strict CSPs

Hi @archmoj and @birkskyum, this new PR also relates to strict CSPs. I mentioned "another issue" in PR #7109 since this is unrelated to fixes discussed in that PR and...