Markus Dlugi

Results 15 comments of Markus Dlugi

This issue is rather old, I guess there aren't any plans on picking this up again, right? @vietj Just wanted to point out that this is also very relevant for...

I think this is the relevant method doing the rewrite in the PostgreSQL JDBC Driver: https://github.com/pgjdbc/pgjdbc/blob/f61fbfe7b72ccf2ca0ac2e2c366230fdb93260e5/pgjdbc/src/main/java/org/postgresql/core/v3/BatchedQuery.java#L89 Called by this method: https://github.com/pgjdbc/pgjdbc/blob/f61fbfe7b72ccf2ca0ac2e2c366230fdb93260e5/pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java#L252 I only had a brief look at the code....

Sounds like a good idea to use `Collectors.joining()` instead of manually concatenating everything, at least would be way more maintainable. However, I'm not quite sure if I understand the idea...

Okay I see, thanks for your help @vietj @Sanne @gavinking What do you guys think? Is this something Hibernate Reactive could support?

> yes sure Hibernate could support this theoretically, but rather than aggregation of individually generated SQL statements I would prefer to generate the optimal SQL right away. > Which implies...

It's the same thing semantically. It's just shorter because you don't need the ternary operator `?:`. You'd just write `check().where(count->count==0)`. So of course you can still achieve the same result...

As an alternative - or maybe in addition? - one could also think about extending the existing `ifNull()` and `ifNotNull()` with some more options. Because you primarily need to do...

Yeah that would basically be what I suggested with `ifApplies(Predicate)`. Would also be fine for me I guess, having at least the predicate method is okay since you can express...

I don't think I know the code base enough to perform such a change, and I currently don't really have the time to dig more into it. Maybe in the...