Marko Stanimirović

Results 153 comments of Marko Stanimirović

Take a look at [this comment](https://github.com/angular/angular/pull/46709#issuecomment-1174873046). If you decided to remove the `markDirty` function, it would be great if you could postpone the removal to v15. :)

Thanks @AndrewKushnir! Btw, `markDirty` is used in the `@ngrx/component` package to mark a component as dirty and schedule tick in zoneless mode. We're using it [here](https://github.com/ngrx/platform/blob/master/modules/component/src/core/render-scheduler.ts#L24).

Thank you, @pkozlowski-opensource. > We really do not believe that this API makes a good zone-less experience I'll appreciate it if you can share more info on this. Do you...

Thank you for your efforts to find a compromise solution @AndrewKushnir. Appreciate that! I think it would be better to remove the `markDirty` function then. Because, without CD scheduling, it...

https://github.com/ngrx/platform/pull/3488 is merged. Thanks for waiting, @AndrewKushnir! :) You can proceed with this cleanup.

@david-shortman The `14_3_2` directory should be renamed to `15_0_0-beta`

@maxime1992 The `tapResponse` is used to keep the effect active if an error is thrown. Because of that, `tapResponse` swallows the thrown error. The `error` callback is not executed, because...

> I would find that weird. For me, or how I think about it, the error callback is to handle errors that are thrown while doing the request, not for...