Mark Fields
Mark Fields
[do not check in] This would allow a follow-up change to switch PSM to be totally batch-based instead of individual messages.
## Description I got confused by the output of itExpects when unexpected errors were logged, because the output was too big but I didn't notice the `...` at the end,...
## Description Fixes [AB#8884](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/8884) If the same batch is submitted twice in parallel by two rehydrated forks of the same container, the duplicate will get sequenced, and all subsequent clients...
## Description Inspired by [AB#7786](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/7786) With the common prefix "FF Assert:" regardless of whether the message is string or hex code, we can update our alerts and queries that monitor...
## Description Reading through this code, I was uncertain when `IPendingMessage.sequenceNumber` should/must be present or not. I found that it's actually very unambiguous in practice - it's only used after...
## Description I got some key parts wrong here, will update later when it's back on track. ~Currently they all use `ISequencedDocumentMessage`. But we know that only "modern" runtime messages...
## Description Reversal of #11915 Always fail afterEach if expected errors don't match logged errors, even if the test itself failed. ### My story why I'm proposing this tl;dr -...
## Description Fixes [AB#19784](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/19784) ContainerRuntime's 'batchBegin'/'batchEnd' events: Removing the `contents` property on event arg `op` The 'batchBegin'/'batchEnd' events on ContainerRuntime indicate when a batch is beginning/finishing being processed. The `contents`...
## Description Fixes [AB#13963](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/13963) We've added a new data structure for tracking "recent" (based on MSN) batchIds which are at risk for seeing a duplicate sequence batchID come in. This...
## Description ~Based on the fact that inbound batches are always processed synchronously, we don't believe the RemoteMessageProcessor will ever have a partial batch in-flight when Summary happens. But maybe...