Mark Fairbanks

Results 116 comments of Mark Fairbanks

> Groups are ignored when computing `.when` I'm sure there was a lot of discussion around this, but I am going to throw in a vote for this being confusing....

In my head `mutate(.by =)` is shorthand for `df %>% group_by() %>% mutate() %>% ungroup()` so `.when` would be calculated after `.by`. Just like the `...` in `mutate()` would be...

> it doesn't work that way, `x = mean(x, na.rm = TRUE)` is only evaluated on the slice of dat where `.when = is.na(x)` is `TRUE` @DavisVaughan I somehow missed...

Makes sense - I'll update the original request.

One thing to note - I think there would have to be a different name because `summarize()` already has a `.groups` arg. Or maybe since it's experimental it can be...

I think a `.groups` arg would be much more intuitive to use. If implemented it would probably supersede `with_groups()`.

Sorry for the late response on this one. `rowwise()` is not currently implemented in `dtplyr`. We should be able to implement this when the newest version of `data.table` is on...

@kurttaylor we’re still waiting on the next CRAN release of `data.table` for the feature to be available. Until then we won’t be able to add it to `dtplyr` unfortunately. `data.table`‘s...

Not sure the best way to handle this one. At first I thought the way to solve this would be by checking if an input dot was an `across` call....

Actually all we would need to do is catch if `arrange`/`filter`/`mutate`/`slice`/`summarise`/`summarize` are called inside of the dot and then return that part of the call unaltered.