Mark Elwin
Mark Elwin
@RoiBites1515 and those who enter via search engine. The script worked wonderfully for me. As of the time of this posting the `read` statements within the script require three user...
I agree @Samyak2. It appears to me that the `sqlite3` connection makes a single `.fetchall()` call for the straightforward, hard-coded `history_SQL` SQL query, described above. It appears to me that...
@ObaraEmmanuel @Samyak2 The three of us are in agreement. I should have some time within the next few days.
Quite good news. I was able to make three non-destructive changes to the mechanism by which the package transfers history files to a temporarily directory and to the SQL query...
@Samyak2 Yes. Quite happy with the results. I will open a PR later this evening or tomorrow. 1. Agreed. I strongly suggest an alternative design pattern that places encapsulates the...
@Samyak2 If you do not follow the rest let us discuss until you do before making suggestions about API changes. I will make one more appeal to you to not...
Please do not make `. history_SQL` private. Firstly the design choice is not incorrect and provides explicit customization for power users. Secondly to do so is a potentially breaking change...
My hunch is you do not want a customer SQL parameter to `.fetch_history()`. Notice that in our simple use case the SQL is still dependent on the Browser class. The...
Those are both the wrong decisions. I am sorry, and I cannot agree with you. What I have suggested in a simple inline function call on the browser object to...