Marius Craciunoiu comments

Results 6 comments of


                                            Marius Craciunoiu

Dynamic height problem

Hi. I was able to get dynamic height working with the following additional styles: ``` scss ul[rn-carousel] { > li { position: relative; margin-left: -100%; &:first-child { margin-left: 0; }...

Dynamic height problem

Hi @tonyawad88, Here's a [plunk](http://plnkr.co/edit/ehcbu9I8bOD7m3PQMXHb?p=preview). Note how there is no fixed height set. The carousel is as tall as the longest slide.

Dynamic height problem

@hughred22 Try setting `display: block` on the images.

giving 0 is translated as true

@vtellier I can't reproduce this locally. Can you provide a minimum test case?

Use JSON.parse when parsing values

Heh, realize this is super old, but what's the benefit of doing that?

Bug Report - Infinite scroll not working when height isn't enough to scroll.

We just ran into this today. @ankeetmaini is there any plan to fix it? Would you accept a PR for this (if yes, do you have some pointers where to...