Marin Lauber
Marin Lauber
No, I haven't done it. I am not sure how to pass the correct time to the function without changing the function arguments.
I am all for it if you want to spend time on this! I think your online app is also a much better way of running the VPP than in...
I am not sure what to do with the plotting script for the logger, it's really ugly and I don't want to include in into `util.jl`. I put it here...
I have added the logger as an extension (via `Plots`). This means that the `examples/TwoD_plots.jl` file is now deprecated. I have modified `examples/TwoD_circle.jl` to show how this looks now. If...
Yes, none of the macros (`@debug` or `@logmsg`) should compromise performance when not used. Maybe `@logmsg` will allow for a custom log level to be set and avoid triggering all...
This is done now; let me know if anything remains to be done. Are we happy with the `Plots` extensions as well?
These are the results of the benchmark. If we are happy with this, I will merge it. ``` Benchmark environment: tgv sim_step! (max_steps=100) ▶ log2p = 6 ┌─────────┬─────────────────┬────────┬───────────┬─────────────┬────────┬──────────┬──────────────────┬──────────┐ │ Backend...
@yongleizhou The YD-41 is only used as an example; the aero and hydrodynamic model are taken from the ORC VPP method, as detailed on the README. Internally, we throw a...
**Benchmark case:** ```julia # the classic... function TGV(; pow=6, Re=1000, T=Float64, mem=Array) # Taylor-Green-Vortex initial velocity field function u_TGV(i,x,t,ν,κ) i==1 && return sin(κ*x[1])*cos(κ*x[2])*exp(-2κ^2*ν*t) # u_x return -cos(κ*x[1])*sin(κ*x[2])*exp(-2κ^2*ν*t) # u_y end...
Yes correct, I will move this and close this PR.