Marten Ringwelski

Config rework

5

This is very mich WIP but it should still be worth looking at right now. The interesting part is `src/config.py`. All other changes are to use the new mechanism for...

Draft: CVE lookup sqlalchemy

3

This PR cleans up much code in the cve_lookup plugin. The main cleanup is to use sqlalchemy instead of generating the SQL statements ourselfes. Many tests are removed since they...

Don't crash when updating when FileObject is alredy in db

1

If a file contained in an already analysed Firmware is uploaded it will be of type FileObject not Firmware.

User defined tags color can't be set

1

The color of user defined tags always defaults to gray. In the code there is support for setting a custom color, but it can't be set through the user interface....

Currently `flask.Markup` is used to make embedding a string in html safe. This could also be done in jinja and we could drop the flask dependency.

Introduce and use analysis_plugin fixture for plugin tests

1

This is a cherrypick of two commits of #763. Depends on #749. The fixture is intendet to reduce complexity of the testing framework. It should be easier to write plugin...

Consider not downloading static files

1

We currently download a bunch of css and js files from various cdn's. See https://github.com/fkie-cad/FACT_core/blob/6922a7b2696d95991bd3ddf603caeeba47d397a3/src/install/frontend.py#L116-L157 From what I know this is unusual. I did some research but didn't find any...

Move plugin results to nested dictionary in processed_analysis structure

2

References #799

Draft: Fix shutdown

1

With this PR only the "root" process receives the SIGINT signal. All other processes irgnore it. The `complete_shutdown()` that just kills the whole processgroup is removed. Also I extracted the...

Currently the configuration is stored in this repo. All linux programs I know that use a configuration either store it in `/etc` or `$XDG_CONFIG_HOME`. I think we should do too....