Marc Rohloff
Marc Rohloff
Fortunately I don't have after hooks though I agree that would make a generic solution tricky. The biggest problem would be triggering before/after blocks without triggering the before after But...
In this case I was trying to access the `instance_options`, but it is confusing that the methods act differently
The serializer is yielded but you can't access instance_options since its protected. Some options I can think of are: * Expose instance_options in the reflection (this is already done for...
It seems a bit pointless to create a PR since you would have to update that line to create a new release. Also, fwiw, I submitted an issue to the...
I realize that. It would be nice to not have the unneeded dependency since sassc is no longer maintained and it seems to be working fine for us. Changing to...
Can this PR be modified so that the Faraday gem is not locked to 2.3? Faraday is already at 2.6
Also wanted to add that Ruby 2.5 reached EOL back in March 2021. Maybe it would be simplest just to remove it from the supported versions
@anilmaurya I am not sure how you'd like to proceed with resolving the code climate issues. The change to core/event either triggers a complexity error or a too many methods...
@mattpolito The existing Mailer `hello_bird` test fails under Ruby 3.2.1 without the patch I agree that it would be good to remove support for earler Ruby (and Rails) versions
We need to decide how to handle this.