Marcin Nowak

Results 39 comments of Marcin Nowak

Thank you for the explanation.

These changes will improve faulty apphooks design: 1. apphooks should be always loaded, when server starts, even if no apphook is bound to any page (published or not) 2. there...

> > you can't load an apphook, if you don't know in which part of the tree it should attached to > > Maybe this a casue of faulty design...

Hi. I can only confirm that I've got to kill zombies myself, too. I'm using rq==0.8. No power failures. It happens from time to time.

Hi. What is the reason of creation of zombie workers? ![Screenshot_20200313_143641](https://user-images.githubusercontent.com/139032/76625740-30d41200-6538-11ea-9bbf-1eee8121bcae.png) They were quite rare until I switched to the master branch. My workers are restarting periodically (via cron, SIGTERM)....

> were you running rqinfo with --interval argument? Yes, set to 5 secs. For each queue: ``` bin/rqinfo -i 5 -u redis://:6379/ ```

Hmm.. I've opened rqinfo (previously 1-2 days ago), and I see something like that: ![Screenshot_20200317_013157](https://user-images.githubusercontent.com/139032/76810697-46bf2c80-67ef-11ea-972e-dcd37fc19614.png) 2 of 6 queues are affected. Timeouts and exceptions happens mostly for both.

I'm investigating zombie workers issue. I've found that zombie workers have less metadata stored in Redis key, and they're exists regardless how task ends. First two are zombie workers, third...

Thanks @selwin. I'm using fork of rq (because of #1216), so I can quickly apply suggested change and check results. I'll create PR if quickfix will work as expected.

I've tried to set hearbeat dependent on job's timeout value. Zombies are still there. ![Firefox_Screenshot_2020-04-01T07-53-55 834Z](https://user-images.githubusercontent.com/139032/78112635-c9a2d280-73fe-11ea-9c9f-05bd9e26fa02.png)