Marcin Dobosz

Results 21 comments of Marcin Dobosz

Hi there, ran into similar problems with opaque type aliases and so I put together this [PR](https://github.com/brigand/babel-plugin-flow-react-proptypes/pull/195) to add support by using the opaque type alias's underlying type information to...

Note that I can obtain a NoopContext by calling `tracer.SpanFromContext(nil)` but then I have to discard the bool, which makes the code more verbose than it needs to be: ```golang...

The code I posted is a simplified example. The `startSpanConditionally` helper does a lot more work (including Extracting/Injecting metadata from a carrier, etc) so I was attempting to avoid allocations...

And to further clarify the conditionality is on a per-subsystem basis (so the global tracer might be Started, but I want to control whether tracing is on in a particular...

@gbbr I'll see how I do time-wise. The `tracer.SpanFromContext(nil)` trick works well enough for now, so feel free to track this internally.

For what it's worth it appears that Google has [no intention](https://github.com/golang/glog/pull/52) of fixing the underlying problem and libraries should just avoid depending on the glog package.

@felixge seems like the easiest might be to lobby for https://github.com/dgraph-io/ristretto/pull/292 and/or https://github.com/dgraph-io/ristretto/pull/293 as it appears dd-trace-go is not the only project affected by glog. Outside of that, have you...

FYI, I already checked in the descriptor name change for [TheoryMethodShouldUseAllParameters](https://github.com/xunit/xunit.analyzers/commit/3f055d5158351a12ae975c722929884a9d1f41d2)

Sorry, just have not had the time to look at everything. I'd like to try out what impact (if any) this change has on the development workflow. There's also a...

Sorry, I've moved on to working on something else and probably won't have enough spare time to tackle this.