Marc McIntyre

Results 28 comments of Marc McIntyre

Same here - which mosfet is for FAN0 on the SKR 1.4? Can someone include a picture?

Any chance that we can get this merged @mattphillips 🙏 ?

Actually, replacing the if (!(target instanceof Element)) check with the following is better... ```js if (target.ownerDocument) { const doc = target.ownerDocument const win = doc.defaultView || doc.parentWindow; if (!win ||...

Hey, So it seems that you want to only allow a specific set of args to calledWith, otherwise you wan to fail the test: Something like: ``` mockApi.get .calledWith(CORRECT_API, "/some-path",...

Hey. Would you be able to add a test that verifies this? Thanks.

I'll merge this into 3.0.0 when that is released (trying to release that asap), since there's a small chance of breaking existing tests.

I'll take a look at this, but suspect that it will not work as you have specified there given how jest works and how I've implemented deep mocks. It may...

unfortunately since Jest does not support this, the only way to add this is to do as above. PRs welcome

I'll try and get a fix for this, without breaking the functionality that added to the slowness.