marcgurevitx

Results 7 comments of marcgurevitx

`.hour()` calls `_dateStr()` which should handle both of those... @kseistrup : Is your area affected by "daylight savings"? If so, maybe this issue should be reopened.

@kseistrup Can you edit the source and add ```c dateTime.tm_isdst = -1; ``` right before this call to [mktime()](https://github.com/JoeStrout/miniscript/blob/e85ec618a6ed11eb04d02a973e42315c19d426d5/MiniScript-cpp/src/DateTimeUtils.cpp#L307) in DateTimeUtils.cpp, line 307 ? It fixes the issue on my...

Probably found the trouble maker (from `man 3 basename` on Linux): > Both dirname() and basename() may modify the contents of path, so it may be desirable to pass a...

Yes. `strdup()` fixed the issue on my machine.

For C++, I think adding ```c if (errno == EOVERFLOW) return ""; ``` after this line should fix it: https://github.com/JoeStrout/miniscript/blob/e85ec618a6ed11eb04d02a973e42315c19d426d5/MiniScript-cpp/src/DateTimeUtils.cpp#L34 (As for C#, don't know...)

Seems like on Windows the problem was on this line (when `_localtime64()` returned `NULL`): https://github.com/JoeStrout/miniscript/blob/e85ec618a6ed11eb04d02a973e42315c19d426d5/MiniScript-cpp/src/DateTimeUtils.cpp#L16 Filed a PR