marcfedorow

Results 28 comments of marcfedorow

https://github.com/gost-engine/engine/blob/624bf7d20c0d1258391bda222d16f099241ad1c1/gost_grasshopper_core.c#L102-L130

Код работает верно (результат правильный). Попытаюсь объяснить, почему я считаю, что код "не в том порядке". Функция делает следующее: ```c void grasshopper_decrypt_block(grasshopper_round_keys_t* subkeys, grasshopper_w128_t* source, grasshopper_w128_t* target, grasshopper_w128_t* buffer) {...

Neither of my custom instructions failed so I am sure it is not an issue of spike. Consider doing this: 1) Ensure that your instruction is listed in encoding.h 2)...

Also note that OpenSSL marks `Sum` functions as `Sigma`, and `Sigma` functions as `sigma`. https://github.com/openssl/openssl/blob/master/crypto/sha/sha512.c It is probably better to use OpenSSL's naming, but I am not sure.

Hi @ben-marshall Actually 0.9.3 bitmanip spec gave RV128 encodings — you can easily assure by checking 7-bit immediate for SLLIU.W (RV32 and RV64 require 5 and 6 bits respectively). Due...

Hi @ben-marshall Thank you for ping! Current descriptions seem to be incorrect tho. shfl (zip) should do 3, 2, 1, 0 stages. unshfl (unzip) should do 0, 1, 2, 3...

@ben-marshall please note that this issue is not resolved yet

Hi @ben-marshall Probably the word "respectively" could stay in both descriptions. Besides this, zip/unzip look good to me now in pre-rc4.

Hi, @ben-marshall As I mentioned [here](https://github.com/riscv/riscv-crypto/issues/115#issuecomment-911662597), brev8 is a very confusing name because it is inconsistent with the old B-ext draft naming scheme. It could be much more clear if...

@ben-marshall May I participate in this meeting? How could I do it?