Marcello Ardizzone

Results 39 comments of Marcello Ardizzone

I'd keep the `.sol` file to make the bindings dynamic Also, can we write a simple test to make sure everything works as expected when it comes to contract instance...

Please make sure the code compiles

Thanks @mrostamii The build seems to be broken, can you please make sure the CI runs successfully? We'll be reviewing the changes then

> @marcello33 CI got failed because `cosmos-sdk` must be updated first. Right, thanks, that's what I mentioned [here](https://github.com/maticnetwork/heimdall/pull/1146#discussion_r1570331647) Ok will let others review the cosmos one, we can then release...

Similar issue here. I launch it with ``` ganache \ --chain.hardfork istanbul \ --miner.blockTime 1 \ --database.dbPath $DATA_DIR \ --wallet.accounts "0x9c08ba1e42bfdd34a017a4bcbf4c92b60e7a497f27534fdb1ac4272c5231d973, 1000000000000000000000" "0x10efc825120aedaa0d7ba3d77a6ec068b63c1893e38f995ee528410a67f8e7a0, 1000000000000000000000" "0x70529f30cf0444a66590625f13e4138ef67a754fd53a58defebfb38f638d5780, 1000000000000000000000" \ --miner.blockGasLimit 8000000 \...

@ZeroEkkusu just committed one more change to solve a vulnerability issue. Please notify me when you are done here. I see only CI/build is failing

> Confirmed that the build was failing because of a `babel` dependency. The build error is now because of a wrong nonce (as expected), but sometimes it's an out-of-gas error....

No problems @ZeroEkkusu. Our prio is to get the whole topic solved around node upgrade (and thus make it work with all devnets deployed via matic-cli). I'll leave this PR...

Hi @livthomas Thanks for your contribution Can you please raise against `develop` branch? I'll run the CI on it.

Hey, @livthomas can you please add a unit/e2e test to make sure pagination works as expected? Thanks