Marc Delagrammatikas comments

Results 7 comments of


                                            Marc Delagrammatikas

Feature/pass opts to with span

Hey @jeffdeville, I'm just getting around to these PRs. Thanks for the work you've done here! Could you give me an example of when you'd want arbitrary static attributes? I'm...

Override default directory for (or pass dir to) take_screenshot/1

Sure, happy to pick up where they left off. Is it easiest if I just submit it as a new PR (I don't know if there's another option tbh)?

Override default directory for (or pass dir to) take_screenshot/1

@tuvistavie are there other methods that could make use of `:temp_dir`? If not, it might be clearer to use `:screenshot_dir` or something to make it more explicit that this value...

make trace_id and span_id types binaries instead of integers

IMHO any tests this would break will be straightforward to fix. I doubt there would be very many since I assume most folks are doing something like `span_id: ^parent_span_id` 99%...

Feature request/proposal: Make extensible how arguments are traced

Hell yeah. I've been noodling on this and came up with almost the exact same solution in our app at work (I think I like your interface better though). I'll...

Roadmap for the Project, and new Maintainer for the Plugin

This is a roadmap-ish question: I'm trying to understand which things are hard/impossible with the plugin API and parser/lexer vs. just haven't been prioritized. Does anyone have a feel for...

Feature Request: `with_event` decorator

Hey @ktayah I've made changes to [o11y](https://github.com/marcdel/o11y/commit/17ef4af317b73db15ac3efdc68997674e80da3c2) to support this feature and am workin on it now. The assumption I'm making (since this will wrap a function) is that the...