Marat Reimers
Marat Reimers
@nishanths I've decided to not refactor code in this PR. 1. I'm not sure how would you like to do it 2. PR is huge even without refactoring (however the...
I don't have concrete suggestions for now. But here are some points of improvement: - Following entities are declared in `switch.go`, but used in `map.go` as well: - `type nodeVisitor`...
@nishanths I'd like to discuss comment association. Here #37 you said: > In the long-term, it is better for the exhaustive program to align with go/ast's definition of associated comments...
> For the first ignore comment, it appears that having it associated with the return statement could work out okay. Since the ignore comment is associated with the return statement,...
I've created PR https://github.com/nishanths/exhaustive/pull/46 to support logic, you described.
Thanks, now it's clear to me. I'll try to prepare PR to support maps.
Have you checked [exhaustruct](https://github.com/GaijinEntertainment/go-exhaustruct)? Looks like it does what you need.
Totally agree, this is the only missing peace.
@julianbrost It is used in several repos, but they are private.