Irina

Results 24 comments of Irina

@metalmatze any updates when this PR could be merged?

Tried to reproduce the issue using testfile.log and config.yaml attached. But I can't reproduce it. I don't see prefixes in loki: Does the issue still remain?

@bradfitz if everything is ok, could you please merge this one?

This is the architecture deployed by this helm chart: ![sampling-recommended-arch-agent-scaled](https://github.com/grafana/helm-charts/assets/2266206/08e0482e-165b-4010-be69-4b62e9dd93f5) The first layer (deployment) receives all OTLP signals and enriches them with k8s.* resource attributes. Then it exports metrics (app...

Shall we put this diagram (the one Cyrille added) to the [DesignDoc](https://docs.google.com/document/d/1DB3jagr6V-2TWs-DRhPddz73lHgYu1upIPg7rVFUxUw/edit#heading=h.3ik6vnncm0n)? So it would be clear that the sampling helm chart covers only the Sampling Box part of the...

> I'll remove these for now but my gut feeling is that not everyone who uses this helm chart will use the k8s monitoring helm chart as well and eventually...

Looks good! Left a couple of comments, I think they should be fixed before merging. Did you exclude logs and metrics pipelines because they should be handled by a separate...

> Is there anything special about the spans this is happening to? Does this happen to a lot of spans or just a few, are they especially short? In the...

I think we can go for it. Adding `resource_to_telemetry_conversion` will also solve another issue https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/2290 So basically, if users trust their downstream configurations and keep the number of resource attributes...