Mark Gerard

Results 89 comments of Mark Gerard

> I am struggling to figure out how to write tests for this. I've started by (very small) factoring of the `verifyMfa` function to put the Okta Push part into...

@sdlevi27 Is this still required? If yes, can you reconcile it to the latest code. If not, we should close it.

@lmottaca-te That is good. Unfortunately, this will bump the coverage down, so I will need it to be accompanied with tests. If you are willing to add tests, I can...

@lmottaca-te Will you help implement tests for this? If not, I am inclined to close the PR

@d-kononov Are you still interested in this? If yes, please fix conflicts so we can merge.

Hey @lxadtz33 Will this fix your issue? https://github.com/Versent/saml2aws/pull/1056

That is interesting. I am not sure how that got mangled up. If you can submit a PR, I can look to merge it. CC: @gliptak

If any of you can submit a PR, we can work to get it merged ASAP.

That is great to hear. Maybe if you can still submit a documentation ticket, I will merge it ASAP!