Mark Gerard comments

Results 89 comments of


                                            Mark Gerard

Fix infinite loop with Okta push

> @wolfeidau @mapkon any chance we could get this merged in? I indeed can. Any chance you can give me some unit tests?

Fix infinite loop with Okta push

@jck @resnikb I was going to merge this until I noticed that it would bump the code coverage down. Please consider adding a test. Thanks

Fix infinite loop with Okta push

@resnikb There are conflicts with master :-( - Let's fix those and roll the tests (as suggested). I want to merge this

Fix infinite loop with Okta push

@briantist / @gliptak - thoughts?

Fix ADFS auth when using MFA with number matching

Is it possible to add a test?

fix gh-36: Add Duo support to ADFS

Hello @dboitnot This is failing the lint-test because `pkg/duo/duo.go` imports the deprecated `io/ioutil`. Mind taking a look?

Added support for browser-type

@eliat123 @gliptak and I did some work on browser.go! It has caused conflicts with this PR. Please take a look and let me know if this is still required.

Added support for browser-type

@dangymbol Would you mind taking on this PR and updating it?

Use Idp Account Name as key for credentials store

LGTM - @wolfeidau / @gliptak - any input on this?

Use Idp Account Name as key for credentials store

> Agreed on the element of surprise, though i think it could be justified to introduce it in a major update for instance. > > WDYT about the fallback scenario?...