Paul Westcott
Paul Westcott
@kevin-montrose Hey Kevin, I took a crack at providing a more optimized System.Linq [here](https://github.com/dotnet/corefx/pull/34208). It was kind of in the opposite direction to you, I was _not_ minimizing garbage, but...
[`BitonicSort.Sort(...)`](https://github.com/damageboy/VxSort/blob/9db7cc60b18545df8a1b5ca8b8a5e5a1a1bc7534/VxSort/BitonicSort.Generated.cs#L984) is only called in [`HybridSort`](https://github.com/damageboy/VxSort/blob/9db7cc60b18545df8a1b5ca8b8a5e5a1a1bc7534/VxSort/VectorizedSort.cs#L214) when the length is less than [`SMALL_SORT_THRESHOLD_ELEMENTS = 112`](https://github.com/damageboy/VxSort/blob/9db7cc60b18545df8a1b5ca8b8a5e5a1a1bc7534/VxSort/VectorizedSort.cs#L144) so it never uses the larges of the `BitonicSortxxV` methods (i.e. 15 & 16). It...
I'm happy to submit a PR if you want me to, but given that I don't know you motivation then I'm not sure which way you want to go (or...
Hi @damageboy I've had a little perusal at the code and I'm not sure if it can be done efficiently (but you are obviously more familiar with the whole thing),...
Just creating PR to get AppVeyor to do some work... This is just a shotgun approach to UseVirtualTag, and still tweaks are required, but should be a reasonable baseline...
...temp removal of code whilst bootstrapping orderby...
Need to execute "selector" part of SelectMany in Count() but not otherwise, which current implementation kinda does (to pass tests, but I don't think it maps all cases. Need to...
Suite of tests [is here](https://github.com/manofstick/Cistern.Linq/blob/f592dfe9fd589fe109ca897bb7f06a3bc802c169/src/Cistern.Linq.Tests/ZipTests.netcoreapp.cs).
Presumable not just this shallow case, but OrderBy and Skip should have relation for fast operation. Test [here](https://github.com/manofstick/Cistern.Linq/blob/master/src/Cistern.Linq.Tests/OrderedSubsetting.cs#L228-L233). Another example in the tests [is here](https://github.com/manofstick/Cistern.Linq/blob/master/src/Cistern.Linq.Tests/TakeTests.cs#L463-L473).
[This skip test](https://github.com/manofstick/Cistern.Linq/blob/master/src/Cistern.Linq.Tests/SkipTests.cs#L480-L511) uses implemenation details. Check what it's supposed to do, and confirm that we're doing it.