Manit Gupta

Results 22 comments of Manit Gupta

I also faced this issue today while trying to build the `Datastream to Spanner` flex template like so: ``` mvn clean package \ -Dimage=${TARGET_GCR_IMAGE} \ -Dbase-container-image=${BASE_CONTAINER_IMAGE} \ -Dbase-container-image.version=${BASE_CONTAINER_IMAGE_VERSION} \ -Dapp-root=${APP_ROOT}...

@lfittl I looked into this issue and the reason seems to be that `go mod vendor` does not correctly include source files from a directory if there are no `.go`...

This `modvendor` solution is also interesting. As a workaround, I had earlier written a script in our Makefile to get the source at the needed version for `pg_query_go` package. ```...

Is there an update on this feature request?

I think this would be useful too! My module is like so - ``` module "gcloud" { source = "terraform-google-modules/gcloud/google" version = "~> 3.4" skip_download = false platform = var.common_params.platform...

I agree that this something we need to get done. This is something we wanted to go to towards the later half of the year. `LocalSpannerIO` got added in the...

Thank you @damccorm and @Abacn for your points. I largely agree with the points you have mentioned here. Specifically - > I'm actually fine with either - I think (1)...

@shreyakhajanchi Please review.

I don't think is being worked upon anymore, closing.

This is my primary motivation - https://github.com/googleapis/java-spanner/blob/main/session-and-channel-pool-configuration.md#automatically-clean-inactive-transactions Currently, there is no way to set `setWarnAndCloseIfInactiveTransactions()`. `SpannerAccessor` is used in Dataflow templates like `DatastreamToSpanner`, which customers use as a black box,...