Manav Sehgal

Results 24 issues of Manav Sehgal

NavLink component did not get updated in last major refactor. It still renders `` as enclosing component. [Source](https://github.com/manavsehgal/react-speed-book/blob/c15-react-developer-experience/app/components/NavLink.jsx#L21) here. **Proposed solution.** Remove and just return Link or `` component. **How...

NavLink propType for children is defined as text. [Source](https://github.com/manavsehgal/react-speed-book/blob/c15-react-developer-experience/app/components/NavLink.jsx#L8) here. **Solution.** Change to propType node so NavLink can handle images as children for example. **Reproduce.** Wrapping NavLink with image child...

1. Add sample controls or components for styles that do not have one 2. Remove styles not used by ReactSpeed 3. Update CSS structure based on best practice followed by...

enhancement
help wanted

[MobX](https://github.com/mobxjs/mobx) seems to be gaining popularity over Redux. Explore creating a sample app using MobX.

enhancement
help wanted

https://www.bithound.io/github/manavsehgal/reactspeedcoding/master/dependencies/npm/postcss-loader#version-details

external dependency

Marked adds significant payload to our production build. Is there a lighter option? BitHound flags Marked as unsafe. Is there a safer option? Compare with https://github.com/showdownjs/showdown

external dependency

1. Use Fetch API to get data from local JSON resource and hydrate a component. 2. Call an external API endpoint to get data for a component.

enhancement

Adding ReactSpeed.com repo. 468 stars.

Thanks for creating this repo. You may want to use GitHub Stars badge instead of hard coding stars count. [GitHub Stars Badge creator tool](https://buttons.github.io/)

Certain datasets may have blanks replaced with NA or other text.

enhancement