Marcel Ludwig comments

Results 11 comments of


                                            Marcel Ludwig

failure should indicate why it failed via RESTful API

See PR #17 I have added a new field `error` which contains the related err message.

set response header on backend network errors

My proposal is to apply user configured headers even on connect errors if applicable. For example: ```hcl set_response_headers = { x-request-id = req.id Cache-Control: no-store ... } ``` This information...

rate limiter as access control

I would apply the ordered list - no magic reordering. Should we reply with some additional headers like https://github.com/sashabaranov/go-openai/blob/master/ratelimit.go#L10 ? This could also be interesting for our BE limiters.

config for disabling the `beta_job` block or delaying on startup

its about the default behaviour which should still be enabled? So the best default boolean is a false one.

Default labels on exported metrics for Prometheus

Hi, since we use this pkg [@avenga/couper](https://github.com/avenga/couper) and have to ensure backward compatibility we came up to a Gatherer Wrapper. This works with v0.33 and those labels are applied to...

Watching of referenced files

It seems a generic implementation for all abs file refs but I am missing any test-case for this.

Either get rid of or stabilize HCL repo fork

fixed in https://github.com/coupergateway/couper/commit/9a89c3d1d76bdd7afcc1f76a1639437fad4b865f

Watch roles_map_file when started in watch mode

Thanks @kevinsandow. #747 has been merged a while ago. Could you please check if the edge/master version works as expected in your case?

Local variables

Seeing no benefits in implementing this; the given example can easily be written in a single line. It’s also quite rare to encounter configurations large or complex enough where local...

Either get rid of or stabilize go-cty repo fork

fixed in https://github.com/coupergateway/couper/commit/9a89c3d1d76bdd7afcc1f76a1639437fad4b865f