Mallory Adams

Generate QR codes internally

8

These commits generate QR codes via PHP instead of via the Google Chart API. This stops sending sensitive data to a third party. Resolves: https://github.com/WordPress/two-factor/issues/42 Note that this uses the...

As a temporary fix I added "window.$ = jQuery" to my JavaScript. It appears in the following two places: src/toolbar/contextual.coffee 91: scrollTop = $('window').scrollTop() src/toolbar/instant.coffee 91: scrollTop = $('window').scrollTop()

When using WorkerPool, PHP fails to flush output before exiting normally

1

I tried to use WorkerPool to parallelise some HTTP requests. It seems to work, except for one mysterious bug: when the main/parent PHP process exits, it fails to flush its...

wp_notify_postauthor() doesn't notify authors in some situations

1

The function does a `foreach` loop over all of the authors of the post. But inside the `foreach` loop, `return false` is used instead of `continue` which means that subsequent...

Some people have names which are one character in length. A guest author with such a name cannot be assigned as the author of a post by typing their name....

Feature request: Allow asserting that trigger_error() is called

1

PHPUnit has `$this->setExpectedException('PHPUnit_Framework_Error_Warning');`. Leo should provide some way of doing this too. Something like this: ``` expect(function () { trigger_error('Oh no!', E_USER_WARNING); })->to->triggererror(E_USER_WARNING, 'Oh no!'); ```

``` PHP Fatal error: Uncaught RuntimeException: phar error: unable to open file "vendor/amphp/amp/docs/asset" to add to phar archive in Standard input code:15 ``` The file is a broken symlink.

`composer require google/apiclient` fails

1

Running `composer require google/apiclient` adds an abnormally huge number of files. And this causes problems when `phar-install` is used as a `post-update-cmd`. In a fairly normal theme that requires `google/apiclient`,...