maksimdrachov

Results 33 comments of maksimdrachov

I prefer the Just the Docs to be honest (I've used it for some other projects before as well :))

Hi, I'm probably going to have a seperate repo for more 'advanced' topics. The reason being: I think it's better to limit myself to the very basic topics in the...

**Question**: Is anonymous listening possible or not? There seems to be some contradiction: `pycyphal/transport/udp/__init__.py:20`: ``` The concept of anonymous transfer is not defined for Cyphal/UDP ``` vs `pycyphal/transport/udp/__init__.py:302` ``` >>>...

**Question**: Does it make sense to move `source_node_id` to `class Frame` (defined in `pycyphal/transport/commons/high_overhead_transport/_frame.py`)?

Ok, thanks. "Datagram" still needs some work, will ping you when a review is needed.

Does the passing of the `local_node_id` as `source_node_id` look right? (see last commit)

I have updated the unit test, to take into account `source_node_id` Functional tests (run `pytest` from `pycyphal/transport/udp`): ![Screenshot 2022-10-15 at 15 21 56](https://user-images.githubusercontent.com/39975120/195986214-b55eac04-4931-4371-8213-fadabd9c43ee.png) Integration tests (`pytest -k udp`): ![Screenshot 2022-10-15...

> Later on, we may want to enable anonymous transfers for UDP as I wrote on the forum; it should be a cheap change to introduce. > The text and...

@pavel-kirienko Could you review these changes? I just want to make sure that this part is correct (`pycyphal/transport/udp/_ip`) before I start updating the larger code base/unit tests. Also some questions:...

Could you confirm the changes are correct? I think I have addressed the issues.