Mark Bumiller

Results 23 comments of Mark Bumiller

license change won't happen - Jxck-S has source files that are purposefully not checked in. Changing the license would mean he has to publish them. Example is `lookup_route.py` - https://github.com/Jxck-S/plane-notify/blob/multi/planeClass.py#L221

this PR may be superceded by #40

@Jxck-S thanks for merging so many PRs yesterday! This is the last change that's keeping me from running straight from the multi branch. Is this legit, or does something else...

use pipenv as defined in the [Readme](https://github.com/Jxck-S/plane-notify#install-pipenv-and-dependencies)

looks like there's already code to query the metadata service for the region - https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-core/lib/aws-defaults/defaults_mode_config_resolver.rb#L65-L86 Setting `AWS_DEFAULTS_MODE=auto` does not seem to set the region. Any chance this can be updated?

The precedence is already environment then profile. I don't see how having the metadata service be the lowest priority (and match how credentials are resolved) is a breaking change. especially...

which backend? from what i can tell the net_http backend is the only one that implements redirects as part of this library. I would assume that's a bug/issue for the...

@janko would you mind taking another look at this pr?