Mai Bui comments

Results 13 comments of


                                            Mai Bui

Add SAG implementation

@superchild Please merge latest master code to trigger Semgrep.

Add exclude option in the Semgrep action yml file

Same as @matthernet. I'd love to have this feature.

Update the Wistron platform support in master branch

@RogerX87 please help add relevant code in this PR https://github.com/sonic-net/sonic-buildimage/pull/12102

[sairedis] Replace memset functions

> can we use memset_s in all places instead doing ifdef ? I don't think so, seems like gcc/g++ doesn't support memset_s

[sairedis] Replace memset functions

/AzurePipelines run Azure.sonic-sairedis

[config] Fix some issues in config.

Please resolve conflicts and merge latest master code to trigger Semgrep.

[config] Fix some issues in config.

Please add unit test to cover this change.

Replace os.system and remove functions with shell=True

> > ``` > > clicommon.run_command(cmd + options, display_cmd=verbose) > > ``` > > The comment is still applicable. > > In reply to: [1320111390](https://github.com/sonic-net/sonic-utilities/pull/2402#issuecomment-1320111390) > > Refers to: show/platform.py:116...

Replace os.system and remove functions with shell=True

> > ``` > > def build_header(self, pg_drop_type): > > ``` > > What is the motivation to change this function? Is it related to the PR title? > >...

sonic-utilities: WRED stats feature changes on sonic-utilities

@rpmarvell Please merge latest master code to trigger Semgrep.